feat: implement onboarding flow and improve ADB error handling - #541
Draft
rteyssandier wants to merge 2 commits into
Draft
rteyssandier wants to merge 2 commits into
rteyssandier wants to merge 2 commits into
Conversation
snappdevelopment
left a comment
snappdevelopment
left a comment
Contributor
There was a problem hiding this comment.
Very cool feature! The new UI looks really nice. I left some comments, because I got stuck a couple times.
| @@ -102,7 +121,19 @@ class SettingsViewModel( | |||
|
|
|||
| fun saveAdbPath() { | |||
Contributor
There was a problem hiding this comment.
To test this, I changed my adb path to an invalid one. I got the red error message in on the settings screen and also in the top app bar. Then I chose my valid path again and clicked the "save" button, but the errors didn't disappear. Only when I clicked on the "test" button, they disappeared.
| @@ -54,20 +60,31 @@ class MessagesServerDelegate( | |||
| } | |||
Contributor
There was a problem hiding this comment.
Reseting the the error when the scope gets cancelled might be a good idea. With something like this:
launch {
try {
awaitCancellation()
} finally {
_serverError.value = null
}
}
rteyssandier
force-pushed
the
feat/onboarding
branch
from
July 29, 2026 17:10
5ed0c6f to
ccba237
Compare
rteyssandier
force-pushed
the
feat/onboarding
branch
from
September 28, 2026 13:51
266ccd9 to
01aaafa
Compare
Introduces a centralized LogManager to track application events, exposed through a new "Logs" tab in the Settings screen. Additionally, updates the Settings UI to use a side-drawer layout and improves ADB process feedback by logging success and error states. chore: downgrade navigation3 version to 1.1.1 Reverts the navigation3 library to the stable 1.1.1 release to resolve compatibility or stability issues encountered with the alpha version. feat: add ADB forward status monitoring to Settings screen Introduces an `AdbForwardStatus` to track the health of reverse port forwarding in the `SettingsRepository`. Updates the Settings UI to display the current connection status and refines log entries with timestamps for better debugging. feat: redesign settings appearance pane and theme selection Refactor the appearance settings to use a card-based layout and update the theme selector with improved visual feedback, including hover states and descriptive icons for each theme option. feat: implement onboarding flow and improve ADB error handling Introduce an initial onboarding wizard to guide users through ADB and SDK configuration. Add system-wide ADB health monitoring, including a new error state in the top bar to alert users of connection issues and provide direct access to the configuration settings. feat: prepare settings UI for onboarding integration The dedicated logs pane is removed to streamline the settings interface. The About section is refactored to allow for direct access to the onboarding flow.
rteyssandier
force-pushed
the
feat/onboarding
branch
from
September 28, 2026 13:52
01aaafa to
9d6b5ec
Compare
Contributor
Author
|
@snappdevelopment I removed the onboarding, I feel like it's more of a pain to maintain that it will be useful. I kept the error handling. But still need to fix your discussions |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce an initial onboarding wizard to guide users through ADB and SDK configuration. Add system-wide ADB health monitoring, including a new error state in the top bar to alert users of connection issues and provide direct access to the configuration settings.