Repository navigation
fix misleading message for missing legacy plugins - #1273
Merged
AmyrAhmady merged 3 commits intoOct 11, 2026
Merged
Conversation
On Linux, Spawn() ignored Canonicalise()'s return value. Canonicalise() uses
realpath(), which fails for a missing file and left the output empty, so the
loader got an empty path: dlopen("") resolves to the main program's handle, and
dlsym("ComponentEntryPoint") matched $CAPI's symbol, wrongly reporting "This
file is an open.mp component." Windows was unaffected (PathCanonicalizeA is
lexical).
Spawn() now reports the missing plugin along with the path it looked for;
Canonicalise() clears its output on failure.
AmyrAhmady
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1272