Repository navigation
Reset vehicle paintjob on respawn and seed cookies after network start - #1278
Closed
AmyrAhmady wants to merge 2 commits into
Closed
AmyrAhmady wants to merge 2 commits into
AmyrAhmady wants to merge 2 commits into
Conversation
Vehicle paintjob was not being cleared in _respawn() while all other modifications (mods, colours, damage) were properly reset, causing the paintjob to persist after vehicle respawn. Fixes #1212
… failures RakPeer::Start() internally calls RakPeer::Disconnect() which resets RakNet internal state. SeedCookie() was called before Start(), meaning the seeded cookie was discarded. Clients connecting in the window between server start and the first onTick() re-seed would fail cookie validation and have their packets silently ignored (issue #1211). Also adds an explanatory comment to the paintjob reset fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the first two commits from #1213 for independent merge. Both commits retain their original authors.
The NPC vehicle death change remains separate for further review.