🌱 Rerun override checks when PR labels change

[tmshort]

Summary

Configure the API diff, CRD diff, Go API diff, and Go version diff workflows to run on PR label additions and removals as well as their default PR events. This makes the existing override labels take effect immediately and reruns the checks if an override label is removed.

Validation

• git diff --check
• Tests not run (workflow trigger changes only).

Summary by CodeRabbit

• Chores
  • API and compatibility checks now run when pull request labels are added or removed.
  • CRD checks also run on label changes; the existing override label remains unchanged.

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	163c39d
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/6ac4fea4079b4c000844caa2
😎 Deploy Preview	https://deploy-preview-2983--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 414a40f0-730a-4671-b620-00e31cfe1104

📥 Commits

Reviewing files that changed from the base of the PR and between 4d33ad1 and 163c39d.

📒 Files selected for processing (4)

• .github/workflows/api-diff-lint.yaml
• .github/workflows/crd-diff.yaml
• .github/workflows/go-apidiff.yaml
• .github/workflows/go-verdiff.yaml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

Four GitHub Actions workflows now run on pull request label and unlabel events. Existing override label values remain unchanged.

Changes

Pull request workflow triggers

Layer / File(s)	Summary
Add pull request label events .github/workflows/api-diff-lint.yaml, .github/workflows/crd-diff.yaml, .github/workflows/go-apidiff.yaml, .github/workflows/go-verdiff.yaml	All four workflows add labeled and unlabeled pull request events. The CRD and Go version diff workflows retain their existing override labels. The API diff lint workflow also removes a trailing blank line.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 163c3

Label changes trigger the relevant override checks within each workflow’s existing scope. No actionable merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 163c3

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

• observed — Modified behavior in .github/workflows/api-diff-lint.yaml: The pull-request trigger now includes labeled and unlabeled events.
• observed — Modified behavior in .github/workflows/api-diff-lint.yaml: A trailing blank line after the job’s environment configuration was removed.
• observed — Modified behavior in .github/workflows/crd-diff.yaml: The pull-request activity types now explicitly include labeled and unlabeled, alongside opened, synchronize, and reopened.
• observed — Modified behavior in .github/workflows/crd-diff.yaml: The override label remains configured as crd-diff-override; its value is unchanged.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: rerunning override checks when pull request labels change. The 🌱 prefix matches the repository’s title guidance.
Description check	✅ Passed	The description summarizes the workflow changes, explains the motivation, and reports validation. It omits the Reviewer Checklist from the template, but the description is otherwise complete.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[tmshort]

#2983 showed me something... so now when labels are added/removed, the checks with override labels (which are pretty quick) are re-run, so we no longer have to manually re-run the failed api diff checks! (This might be a bit weird when lgtm and approved are added, but they're quick and relatively minor)

[tmshort]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• .github/OWNERS [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fgiudici]

/lgtm

[fgiudici]

TIL 💡: default is opened, synchronize and reopened so this allow to run on labels change!