Repository navigation
[EHS-50] Add gh actions for publishing the package to jfrog - #23
Merged
Merged
Conversation
Anwar Hossain (anwar-opti)
commented
Nov 18, 2025
Anwar Hossain (anwar-opti)
commented
- we don't have any gh actions to automate the publishing of packages to jfrog
- this PR aims to add the gh actions for that
Farhan Alam (farhan-opti)
requested changes
Dec 11, 2025
Farhan Alam (farhan-opti)
left a comment
Farhan Alam (farhan-opti)
left a comment
There was a problem hiding this comment.
Both yarn.lock and package-lock.json are present. Is there a reason we need both? To avoid inconsistent installs, we should keep only one lockfile.
Md. Mahadi Hasan Sourav (mahadi-sourav)
approved these changes
Dec 11, 2025
Md. Mahadi Hasan Sourav (mahadi-sourav)
left a comment
Md. Mahadi Hasan Sourav (mahadi-sourav)
left a comment
There was a problem hiding this comment.
Change looks great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.