Repository navigation
[FSSDK-11901] Fix concurrency bug in cmab service - #462
Merged
Farhan Anjum (FarhanAnjum-opti) merged 4 commits intoOct 15, 2025
Merged
Farhan Anjum (FarhanAnjum-opti) merged 4 commits into
Farhan Anjum (FarhanAnjum-opti) merged 4 commits into
Conversation
![prisma-cloud-devsecops[bot]](https://avatars.githubusercontent.com/in/135857?s=60&v=4){kind=small}
Raju Ahmed (raju-opti)
previously requested changes
Oct 8, 2025
Farhan Anjum (FarhanAnjum-opti)
requested a review
from Raju Ahmed (raju-opti)
October 9, 2025 15:23
Matjaz Pirnovar (Mat001)
requested changes
Oct 10, 2025
Matjaz Pirnovar (Mat001)
approved these changes
Oct 13, 2025
Matjaz Pirnovar (Mat001)
left a comment
Matjaz Pirnovar (Mat001)
left a comment
Contributor
There was a problem hiding this comment.
Now looks ok. Glad we are removing Py and pypy 3.8. It's getting out of security updates support.
Farhan Anjum (FarhanAnjum-opti)
dismissed
Raju Ahmed (raju-opti)’s stale review
October 15, 2025 09:01
Changed
Farhan Anjum (FarhanAnjum-opti)
merged commit Oct 15, 2025
116d23a
into
master
35 of 36 checks passed
Farhan Anjum (FarhanAnjum-opti)
deleted the
farhan/FSSDK-11901-fix-concurrency-bug-in-cmab
branch
October 15, 2025 09:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes concurrency bug in cmab service by introducing locking in order to ensure consistent result.
Test plan
Introduced unit tests
Issues
FSSDK-11901