Repository navigation
zephyr: Add CONFIG_LIBOSDP_TRS to build TRS - #333
Merged
Merged
Conversation
Transparent Reader Support is gated by OPT_BUILD_OSDP_TRS in the CMake and configure.sh builds, but the Zephyr module had no way to turn it on: osdp_trs.c was never compiled and the define never set, so a Zephyr PD or CP could not use osdp_XWR / osdp_XRD. Add an opt-in LIBOSDP_TRS Kconfig option that defines OPT_BUILD_OSDP_TRS for the library and adds osdp_trs.c. Default off, so existing builds are unchanged. Checked on native_sim: osdp_get_abi_info() reports OSDP_ABI_OPT_TRS only with CONFIG_LIBOSDP_TRS=y, and both configurations link. Signed-off-by: Marek Janský <marek.jansky@ima.cz>
sidcha
approved these changes
Oct 20, 2026
sidcha
left a comment
sidcha
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks.
PS. I didn't enable the zephyr path (along with many others) because TRS mode hasn't been stabilized yet. I am okay with merging this patch but please don't expect it to work out of the box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transparent Reader Support is gated by OPT_BUILD_OSDP_TRS in the CMake and configure.sh builds, but the Zephyr module had no way to turn it on: osdp_trs.c was never compiled and the define never set, so a Zephyr PD or CP could not use osdp_XWR / osdp_XRD.
Add an opt-in LIBOSDP_TRS Kconfig option that defines OPT_BUILD_OSDP_TRS for the library and adds osdp_trs.c. Default off, so existing builds are unchanged.
Checked on native_sim: osdp_get_abi_info() reports OSDP_ABI_OPT_TRS only with CONFIG_LIBOSDP_TRS=y, and both configurations link.