Repository navigation
Show the output of the image push task - #2832
Merged
Merged
Conversation
The "Run push script" task was marked no_log, so when docker push fails the job log only says "Output suppressed because no_log was given". The actual error (registry 5xx, connection reset, timeout, authorization failure) is lost, and a failed push cannot be diagnosed from the job output. The task handles no secrets. The registry credentials are only used by the preceding docker_login task, and the push script itself runs nothing but git rev-parse, docker tag and docker push, none of which print credentials. no_log therefore protects nothing and only hides the error. Drop no_log from the push task. The tasks that do handle secrets are unchanged. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. Docker push progress and image details will now appear in build logs. Reverting suppresses future output, but it does not remove details already recorded; those logs are bounded and can be cleared.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Run push scripttask is markedno_log, so a faileddocker pushleaves only "Output suppressed because no_log was given" in the job log. The registry's actual error is lost and the failure cannot be diagnosed afterwards.The task handles no secrets: the registry credentials are used by the preceding
docker_logintask, and the script only runsgit rev-parse,docker taganddocker push. This dropsno_logfrom that one task; the tasks that handle secrets are unchanged.The push task only runs when
push_imageis set (periodic and tag pipelines), so thecheckrun of this PR skips it. The change takes effect with the first periodic run after merge.🤖 Generated with Claude Code