fix(MenuToggle): allow direct string boolean for aria-haspopup

[kmcfaul]

What: Closes https://redhat.atlassian.net/browse/PF-4712

Summary by CodeRabbit

• Bug Fixes
  • Menu toggles now accept the string values "true" and "false" for the aria-haspopup property, in addition to the existing "menu", "listbox", and boolean values. This keeps the property’s accepted values consistent whether it is provided as a string or a boolean.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: a6e44ede-1d8b-4211-84b7-2979f7342ec4

📥 Commits

Reviewing files that changed from the base of the PR and between 34d2974 and 53355bd.

📒 Files selected for processing (1)

• packages/react-core/src/components/MenuToggle/__tests__/MenuToggle.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

---

Walkthrough

The MenuToggleProps['aria-haspopup'] type now accepts the string literals 'true' and 'false'. Tests check rendering for those strings and their boolean equivalents.

Changes

MenuToggle aria-haspopup

Layer / File(s)	Summary
Extend aria-haspopup values packages/react-core/src/components/MenuToggle/MenuToggle.tsx, packages/react-core/src/components/MenuToggle/__tests__/MenuToggle.test.tsx	MenuToggleProps['aria-haspopup'] now includes the string literals 'true' and 'false'. Tests check that string and boolean values render as corresponding string attributes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 53355

The requested string values are accepted and rendered, with tests covering both strings and booleans. No actionable merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: allowing direct string boolean values for aria-haspopup in MenuToggle.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[wise-king-sullyman]

🥳

[patternfly-build]

Your changes have been released in:

• @patternfly/react-code-editor@6.7.0-prerelease.6
• @patternfly/react-core@6.7.0-prerelease.6
• @patternfly/react-docs@7.7.0-prerelease.7
• @patternfly/react-drag-drop@6.7.0-prerelease.6
• demo-app-ts@6.5.0-prerelease.136
• @patternfly/react-table@6.7.0-prerelease.7
• @patternfly/react-templates@6.7.0-prerelease.6

Thanks for your contribution! 🎉