Repository navigation
Fix/editor chrome numeric field border - #6
Conversation
Added fully translated and verified Romanian.json file for Subtitle Edit version 5.x.
Keep the new wording, but:
- restore the English numeric format specifiers in the 14 File > Statistics
strings ({0:0.000}, not {0:0,000} - the comma is a group/scaling specifier)
- move to the current English.json key layout (shared strings under general),
so the 38 strings that had regressed to English are translated again and the
94 stale keys are gone; every key now exists in English.json
- put back the _ access keys on menu items and buttons (108 added)
- use linii / subtitrare consistently instead of mixing in rânduri / subtitlu
- keep "Viridis" (colour map name), use "Atașamente" for ASSA attachments,
translate the values that were still English (Styles, Renumber, Merge, ...)
- fix "Tradus de Constantin Popa)", the point-sync menu item, and distinguish
Abort ("Abandonare") from Cancel ("Anulare")
- LF line endings like the other language files
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Add Romanian language translation for v5
The editor-look windows (Settings and every window on EditorChrome) set explicit font sizes and 28 px field heights, so the global "Font scale (%)" setting, which works through the inherited window font, never reached them. Route the shared chrome sizes through the setting, keep icons at their size, and re-apply the Settings styles on Apply so a changed scale shows live. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…-resize-global-setting-97bae1 Editor look: follow the Font scale (%) setting (SubtitleEdit#16242)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd757f3ec0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| Text = section.Title, | ||
| FontSize = 12.5, | ||
| FontSize = EditorChrome.FieldFontSize, |
There was a problem hiding this comment.
When the user changes Font scale and clicks Apply, this local FontSize remains the value computed when the Settings page was constructed. Apply() reapplies styles and RefreshSections() rebuilds only the selected content section, while the side-menu buttons are retained in _menuButtons; UiTheme.ApplyScaleToWindow() also updates only explicit sizes carrying DesignFontSizeProperty. Consequently the settings fields resize immediately but the category labels retain the old size until the window is reopened. Recreate/update these labels or opt them into DesignFontSizeProperty.
Useful? React with 👍 / 👎.
No description provided.