Repository navigation
fix(tia): drop coverage lines the current file no longer has - #2001
Merged
MrPunyapal merged 3 commits intoOct 31, 2026
Merged
Conversation
An edited file left the previous line numbers in the cache as uncovered, and a revert did not remove them. Fixes pestphp#1954
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
When a covered file's lines moved,
--tia --coveragekept the old line numbers incoverage.bin.gzas executable lines with no tests. The report counted them. Reverting the file did not remove them, so--min=100kept failing on a suite that was back at 100%.A file measured in the current run now owns its line map. Cached lines that are not in that map are dropped before the merge. Lines that still exist keep hits from tests that were replayed.
Related:
Fixes #1954