[apael]

Title: fix(sharding): strip --runner from the --list-tests sub-process

What:

• Bug Fix
• New Feature

Description:

php artisan test --parallel --shard=1/3 fails before running anything:

$ php artisan test -p --shard=1/3 tests/Unit

Symfony\Component\Process\Exception\ProcessFailedException

The command "'php' 'vendor/pestphp/pest/bin/pest' '--configuration=.../phpunit.xml'
'--runner=\Illuminate\Testing\ParallelRunner' 'tests/Unit' '--cache-directory'
'/tmp/__laravel_test_cache_directory' '--no-output' '--no-progress' '--list-tests'" failed.

Exit Code: 2(Misuse of shell builtins)

Unknown option "--runner". Most similar options are --filter, --stderr, --uses, --all, --columns

Without a shards.json, Shard discovers the test classes by re-running its own arguments with --list-tests. removeParallelArguments() takes out --parallel, -p and --processes, but Laravel's artisan test also passes --runner=\Illuminate\Testing\ParallelRunner in parallel mode. That argument reaches the sub-process, which does not run in parallel and so rejects it.

--runner is a parallel-only argument just as --processes is, so this strips it the same way. A unit test covers buildListTestsCommand() with Laravel's runner argument.

Related:

Same family as #1454 / #1731 / #1756 (--processes leaking into --list-tests).

[MrPunyapal]

Could you also handle --runner Runner, alongside --runner=Runner? The current filter removes --runner but leaves its value in the list-tests command. I reproduced this locally. Please add a regression test for the space-separated form.

[apael]

Thanks, good catch. --runner Runner now drops both the flag and its value (fb81069), and there is a regression test for the space-separated form; it fails without the change. The value is only consumed when it does not itself start with -, so a bare --runner followed by another option leaves that option alone.