Repository navigation
Extend the selected cell range on shift + click. - #9
Merged
Merged
Conversation
This was referenced Oct 15, 2026
Shift + mousedown on a cell now extends the selected range from the currently selected cell, as shift + arrow keys do, instead of moving the selection. Clicking the selected cell without shift collapses an extended range back to that cell, and shift + click whilst editing commits and closes the editor. Refs pgadmin-org/pgadmin4#8647
dpage
force-pushed
the
fix/shift-click-range-selection
branch
from
October 15, 2026 12:08
ee4c6cf to
eea23f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For pgadmin-org/pgadmin4#8647 ("Cell range selection on shift + click should work").
What changed
enableRangeSelection, shift + mousedown on a cell now extends the selected range from the currently selected cell (the anchor) to the clicked cell, in the same way as shift + arrow keys, rather than moving the selection. Repeated shift + clicks keep the same anchor. With range selection disabled, shift + click behaves as a normal click.SelectCellOptionsgains an optionalextendRangeflag.lib/is rebuilt, since pgAdmin installs this fork straight from git.Test plan
test/browser/rangeSelection.test.tsxgains tests for shift + click extending the range downwards/rightwards and upwards/leftwards, repeated shift + click keeping the anchor, plain click resetting the range (including on the anchor cell), and shift + click behaving as a normal click when range selection is disabled. They pass in Chromium and Firefox, and four of the five fail without the change.resizable.test.tsx("should remeasure flex columns"), which also fails onmain.