Skip to content

fix(filetree): wrap long comments without requiring hover - #52

Merged
Vonng merged 3 commits into
pgsty:mainfrom
hugegraph:fix/filetree-readable-comments
Oct 17, 2026
Merged

Vonng merged 3 commits into
pgsty:mainfrom
hugegraph:fix/filetree-readable-comments

Conversation

@imbajin

@imbajin imbajin commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Fixes #51.

Problem

FileTree comments are clipped to a single line on desktop and tablet. Even the widest divider setting can leave long descriptions unreadable without hovering.

Before After
Comments clipped at the widest divider setting Complete comments wrap within their rows

Change

  • Let comment text wrap, including unbroken tokens, and let rows grow from their existing minimum height.
  • Keep filename truncation, directory disclosure, divider controls, and mobile stacking.
  • Add source regression tests and EN/ZH fixtures to the owning output checker.

Long-comment trees become taller; no JavaScript, dependency, or setting is added.

Validation

Existing native comparisons cover English/Chinese, desktop/tablet/mobile, light/dark, divider resizing, and print. Full-site and broader browser/device validation are not established; no new local test run is claimed here.

imbajin added a commit to imbajin/oink.pgsty.com that referenced this pull request Oct 14, 2026
…policy

- Document screen/print Markmap text contract and fixed TOC footer clearance
- Document FileTree comment wrapping without clipping or requiring hover (pgsty/oink#52)
- Document table width policy, .td-table--wide explicit marker, and boundaries (pgsty/oink#54)
- Maintain bilingual parity, line-wrapping conventions, and heading anchors across EN/ZH
- Distinguish published v1.2.0 behavior from post-v1.2.0 unreleased capabilities
@Vonng

Vonng commented Oct 17, 2026

Copy link
Copy Markdown
Member

Thanks @imbajin! Merged via #57 with your original commits preserved.

The final interface makes the layout choice explicit:

  • Omitted wrap, or wrap=false, keeps the existing compact rows.
  • wrap=true shows complete comments, including long unbroken identifiers, and lets rows grow.
  • Filenames keep ellipsis. Directory disclosure, divider keyboard/pointer controls, mobile stacking, and expanded Print keep their existing behavior.

Invalid values warn and fall back to false; strict builds reject the warning. Markdown output preserves the explicit parameter.

Validation passed: the full theme CI, 60 documentation-site non-browser tests, the strict production build, all 381 browser cases including a 425-page accessibility scan, and 48 focused FileTree checks across Chromium, Firefox, and WebKit. The new release post also exposed a stale expected sidebar list in the site tests; that expectation was updated and revalidated.

The 1.3.1 CHANGELOG and prepared bilingual release notes credit your Markmap, TOC, FileTree, technical-table, and documentation contributions. The guide and Design contract are updated in pgsty/oink.pgsty.com#11. The theme change is on main; v1.3.1 has not been tagged yet.

@imbajin
imbajin deleted the fix/filetree-readable-comments branch October 17, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] FileTree long comments cannot be read fully without mouse hover

2 participants