Repository navigation
fix: use static C strings for cached HTTP methods - #2789
Merged
Merged
Conversation
C.CString allocations kept only in a Go map are invisible to LeakSanitizer, which reports them as direct leaks in every fuzz target (OSS-Fuzz issue 578554565).
alexandre-daubois
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP method strings cached at package init were allocated with `C.CString` and only referenced from a Go map. LeakSanitizer doesn't scan Go memory in libFuzzer builds, so OSS-Fuzz reports them as a direct leak (53 bytes in 9 objects) in every fuzz target: https://issues.oss-fuzz.com/issues/578554565
This makes them static C literals. They live in a new file because `cgi.go` uses `//export`, which forbids definitions in its preamble.
Reproduced with the OSS-Fuzz build (go-118-fuzz-build + clang `-fsanitize=fuzzer,address`): the leak is reported on `main` and gone with this patch.