Repository navigation
tests: pin the adapter lookup-index populations with a read-only probe - #711
Closed
luisleo526 wants to merge 2 commits into
Closed
luisleo526 wants to merge 2 commits into
luisleo526 wants to merge 2 commits into
Conversation
Add a read-only reader over the Pine adapter's lookup indexes (probe_lookup_index, in a source-layer header that is not installed) and a test that pins how many keys and ids the indexes hold for four streams: cohort sides, unbound legs, legs by origin and immediate closes. Every expected count is computed from the commands the test itself issues and a named retention rule, for two input populations and several read points, including a read after a later position cycle. The reader only calls size() and iterates by const reference; the adapter change is the include and the reader, nothing else. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Brings the branch up to date with main (87 files, mostly tests and CI). The branch's own paths do not overlap with anything main changed except tests/CMakeLists.txt, which this branch does not edit. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a read-only probe and a test that pin the populations of the adapter's lookup indexes.
src/source/pine_adapter_probe.hppdeclares a read-only reader;pine_adapter.cppdefines it (size() and const iteration only, no allocation or mutation). The header is not installed and the library is built with hidden visibility, so the reader is not reachable from a run.tests/test_adapter_lookup_index_counts.cppdrives the adapter, keeps an independent command ledger as its model, and compares the model with the probe at each read point (with nonzero-population checks and no literal expectations).Draft: it rides the next engine merge train, which rebases it on main and runs the full checks and the parity sweep.
🤖 Generated with Claude Code