Repository navigation
[GHA] Disable upstream's security audit and release workflows - #6
Merged
Merged
Conversation
The upstream syncs brought in a nightly security audit and left upstream's release workflows active, most of which run on every pull request. None of it applies to the fork: releases go through xelp_npm_release, and the audit's allowlist is maintained upstream for upstream's own tree. Rename the workflows to .disabled, as the formatter fork already does, and drop the build's upstream-only steps.
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Copilot review overview
2 open findings
What changed in this PR
Removes the Coveralls coverage upload step from the GitHub Actions build workflow (including a previously hardcoded repo token).
Changes:
- Deleted the Coveralls upload step from the CI workflow.
- Removed an in-repo hardcoded Coveralls token and its accompanying rationale comment.
| File | Description |
|---|---|
| .github/workflows/build.yml | Drops Coveralls coverage upload step (and removes hardcoded token) from CI. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
21
to
23
| - run: npm run build | ||
| - run: npm run lint | ||
| - run: npm run test |
Comment on lines
21
to
25
| - run: npm run build | ||
| - run: npm run lint | ||
| - run: npm run test | ||
| - name: Upload coverage to Coveralls | ||
| if: matrix.os == 'ubuntu-latest' | ||
| uses: coverallsapp/github-action@v2 | ||
| env: | ||
| #hardcode the coveralls token...it's not overly important to protect, and github actions won't allow forks to work with coveralls otherwise | ||
| COVERALLS_REPO_TOKEN: "kVPcGJfehOArEQnHb8BT3KS72xbUQCoxI" | ||
| with: | ||
| path-to-lcov: ./coverage/lcov.info | ||
| # this is stalling out for some reason, so disable it for now | ||
| #- run: npm run test-related-projects No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.73.6 sync brought in upstream's nightly Security Audit, and upstream's release workflows were never disabled here, so most of them run on every pull request (Make Release Artifacts ran on #5). None of it applies to the fork: releases go through Xelp npm Release, and the audit's allowlist is maintained upstream for upstream's own tree.
This renames
create-package,create-vsix,initialize-release,make-release-artifacts,publish-release, andsecurity-auditto.yml.disabled, matching the formatter fork, and drops the build's upstream-only steps.