Repository navigation
fix(flexbox): allow sub-pixel slack when measuring text against yoga widths - #131
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yoga hands the measure function a float32-rounded width that can be a hair smaller than the text's own width, and layoutText compares with no tolerance. So short labels like "TV-14" split into "TV-1" / "4" and "R" rendered as an empty box (RNG-908, rating badge in the RN Lightning preplay). It depends on which way the rounding goes, so PG-13 and TV-MA were fine.
Adds 0.01px of slack in YogaManager._measureText when the width is bounded. Way below one glyph, and the renderer already gets +2px when it paints, so real wrapping doesn't change. Covers the worker path too since it runs the same YogaManager. New integration test fails without the fix.
react-native-client carries this as a pnpm patch on 1.0.0-alpha.5 for now.