Repository navigation
fix(focus): claim and directional search fixes - #134
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four FocusManager fixes from running the Plex Lightning app on native-style focus (on top of the claim patience in #133).
['last-focused', episodeKey]moves to the episode when the key shows up a few ms late instead of staying on its fallback.Caveat: the last one means a later autoFocus child can still take the slot in a claimed region until the user moves in it. Seems right to me, since a claim landing is a mount-time default, but shout if that bites.
Tests: 382 pass, 5 new regression specs (all failed before). One patch changeset per fix.