Repository navigation
Add atomic quick-join for public lobbies - #407
Merged
Merged
Conversation
koenbollen
reviewed
Oct 23, 2026
koenbollen
reviewed
Oct 23, 2026
koenbollen
reviewed
Oct 23, 2026
koenbollen
reviewed
Oct 23, 2026
erikdubbelboer
commented
Oct 23, 2026
erikdubbelboer
force-pushed
the
quickJoin
branch
from
October 26, 2026 04:36
a7e7357 to
27be287
Compare
ErikSom
approved these changes
Oct 27, 2026
koenbollen
approved these changes
Oct 28, 2026
| type Store interface { | ||
| CreateLobby(ctx context.Context, Game, LobbyCode, PeerID string, options LobbyOptions) error | ||
| JoinLobby(ctx context.Context, game, lobby, id, password string) ([]string, error) | ||
| JoinOrCreateLobby(ctx context.Context, game, peerID, country, region, lobbyFilter string, generateCode func(attempt int) string, options LobbyOptions) (string, []string, bool, error) |
Collaborator
There was a problem hiding this comment.
This fun arg is not super nice. Don't know a better alternative rn.
Add `network.quickJoin()` to join the oldest available public lobby or create one. Serialize this per game so simultaneous requests don't create separate lobbies. Reuse lobby creation settings, excluding visibility and passwords. Apply these settings only when creating a lobby.
erikdubbelboer
force-pushed
the
quickJoin
branch
from
October 28, 2026 13:13
27be287 to
a12ec68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
network.quickJoin()to join the oldest available public lobby or create one. Serialize this per game so simultaneous requests don't create separate lobbies.Reuse lobby creation settings, excluding visibility and passwords. Apply these settings only when creating a lobby.