Repository navigation
xpay: hold payments until its init replies are in - #78
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xpay sends
getchaininfo,getinfoandaskrene-create-layerat init without waiting for the replies, so a payment can arrive before them. A payment before thegetinforeply used an uninitializedlocal_idand aborted xpay insecp256k1_ec_pubkey_serialize. A payment before the layer existed failedaskrene-agewith "Unknown layer", which also killed the plugin.xpay,xpay-as-pay,sendamount,xkeysendandpaytaken over through therpc_commandhook are now held until all three replies are in, then run as usual. The tests hold each reply from a test plugin, and both crashed xpay before this change.Closes #14
Changelog-None