Repository navigation
gossipd: remove channels funded before the activation from the store at startup - #81
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gossipd ignores gossip for channels funded before the BLAKE2b activation as it arrives, but a gossip store written by an earlier version still holds their announcements and updates, and they were loaded and kept. On an upgraded mainnet node nearly the whole graph came from such channels, so route finding picked paths through nodes that had not upgraded.
On startup gossipd now removes every channel below the activation from the store, through the same path pruning uses. A channel already dying is left to its 72 block deadline. On the mainnet test store this removes 50,808 channels and adds about 1.8s to that one start, and the next start has nothing to remove.
Two tests restart a node with the activation set: one checks the channel below goes and the one above stays, the other that a dying channel is removed at its deadline and not before. Both fail without this change.
Closes #20
Changelog-None