Repository navigation
lightningd: only resend announcement_signatures for a channel we announce - #86
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A peer can ask for our
announcement_signaturesagain through theretransmit_flagsofmy_current_funding_lockedinchannel_reestablish. lightningd now answers that request only in the gossip states where it sends its signatures on its own (waiting for the peer's signatures, waiting for announce depth, announced), and ignores it for channels that are private or not yet confirmed.channeld gets a developer-mode hook,
CLN_DEV_REQUEST_ANNOUNCEMENT_SIGS, so tests can make our node set the flag the way other implementations do. The new tests cover unconfirmed, zeroconf and private channels, which get no signatures, and an announced channel, which still gets them.Changelog-None