Skip to content

[CP v2.16] Show the CHIP server Node ID once the server has started - #137

Merged
rquidute merged 1 commit into
project-chip:v2.17-cli-developfrom
rquidute:fix/1193-cli-node-id-after-server-start-v2.17
Oct 28, 2026
Merged

rquidute merged 1 commit into
project-chip:v2.17-cli-developfrom
rquidute:fix/1193-cli-node-id-after-server-start-v2.17

Conversation

@rquidute

Copy link
Copy Markdown
Contributor

Cherry-pick of #136 (ba40a92) from v2.16-cli-develop. Requires the matching backend PR (server_started field).

The CLI now watches /chip-server/info and shows the Node ID and manual pairing code once the chip server has started, instead of a stale ID fetched at executing.

The squash commit also includes the regenerated API client from #136: it drops the unused utils_api (no /utils endpoint in the backend) and updates models.py. Applied cleanly; pytest tests/test_run: 431 passed.

Refs #1193

…p#136)

* Show the CHIP server Node ID once the server has started (#1193)

The Node ID is regenerated when the chip server starts during suite setup,
after the run is already executing, so the one-shot query at 'executing'
printed a stale ID. Watch the backend instead and display the Node ID (and
manual pairing code) whenever the server is started and the ID changes.

* Treat only an explicit server_started=False as not started

A backend that predates the server_started field omits it; defaulting to False
would suppress the Node ID banner entirely (#1193).

* Re-generated api classes

* isort

(cherry picked from commit ba40a92)
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b759990e-6ca0-407e-8e51-d50af258cea5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@rquidute rquidute self-assigned this Oct 28, 2026
@rquidute
rquidute requested a review from antonio-amjr October 28, 2026 17:17
@rquidute
rquidute merged commit 945a054 into project-chip:v2.17-cli-develop Oct 28, 2026
5 checks passed
@rquidute
rquidute deleted the fix/1193-cli-node-id-after-server-start-v2.17 branch October 28, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant