Repository navigation
ci: bump Python for the OpenMetrics check to 3.15 - #3169
Merged
Merged
Conversation
ubuntu-latest now resolves to Ubuntu 26.04, for which actions/setup-python has no Python 3.12.3 build, so the check-abnf job fails during setup. Python 3.15 is available there. Use the minor version instead of an exact patch release so the job keeps working across runner image updates. The ABNF and version checks were verified to pass on Python 3.15.2. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ubuntu-latestnow resolves to Ubuntu 26.04, andactions/setup-pythonhas no Python 3.12.3 build for it (3.12.3 is only published up to Ubuntu 24.04). Thecheck-abnfjob therefore fails in the "Set up Python" step for any PR that touchesdocs/specs/om/open_metrics_spec_2_0.md, for example om2: OpenMetrics 2.0.0-rc1 #3167.python-versionto"3.15", which is available on Ubuntu 26.04. The minor version is used instead of an exact patch so the job keeps working when runner images change.Test plan
python:3.15.2container:abnfinstalls from the pinned requirements, the grammar parses, all 47 examples in the spec parse (check_openmetrics_spec.py), and the version bump check passes (check_openmetrics_spec_version.py).actions/python-versionsmanifest: 3.15.2 is published for Ubuntu 26.04.OpenMetricsworkflow only runs on PRs touching the spec, so it will not run on this PR; it should turn green on om2: OpenMetrics 2.0.0-rc1 #3167 once this is merged and main is merged intoom2-rc1.