Repository navigation
Conversation
The installation step linked to a pre-modules article about the go command. Point it at the module-aware go get reference instead, as suggested by machine424 in the review of prometheus#2563. Also make the prose match the code on the page: both examples use promhttp.HandlerFor with a custom registry, not promhttp.Handler; the first example exposes Go and process metrics; and the second example exposes only its custom counter. Refs prometheus#2556 Assisted-by: Claude Opus 5.5 Signed-off-by: hd <63141252+hnrydvd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RichiH, for docs
Fixes the outdated
go getlink in the Go guide and makes the prose match the code.promhttp.HandlerFor(reg, ...)with a custom registry. The text still namedpromhttp.Handler, which only serves the default registry.go_*andprocess_*metrics. App 2 uses its own registry and exposes onlymyapp_processed_ops_total. The old summary said it "also" exposed the Go metrics.