Repository navigation
Honor DWORD-aligned rows in 24-bit BMP textures - #108
Open
PS2HomeDeveloper wants to merge 2 commits into
Open
PS2HomeDeveloper wants to merge 2 commits into
PS2HomeDeveloper wants to merge 2 commits into
Conversation
## Summary Uncompressed BMP scanlines are DWORD-aligned, but the 24-bpp loader advances through source data as if each row were exactly `width * 3` bytes. When a row has padding, the loader reads padding bytes as pixel data for the next row and the texture colors are corrupted. Calculate and validate the 24-bpp source-row stride, then index each source row using that stride. ## Testing - Build gsKit with the PS2 toolchain. - Load 24-bpp BMPs with widths 1, 2, and 3 and at least two rows; use distinct colors per row and verify row order and colors. - Load a 24-bpp BMP with width 4 to verify that rows without padding remain correct. - Verify a truncated 24-bpp pixel payload is rejected before row data is accessed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uncompressed BMP scanlines are DWORD-aligned, but the 24-bpp loader advances through source data as if each row were exactly
width * 3bytes. When a row has padding, the loader reads padding bytes as pixel data for the next row and the texture colors are corrupted.Calculate and validate the 24-bpp source-row stride, then index each source row using that stride.
Testing