Skip to content

Session Handoff [auto-2724]: Narrow pr_review.py wait's Exit 44 to Required Checks for #2724 #2726

Closed

Description

@ptr727

Next steps, in priority order

  1. Fix Narrow pr_review.py wait's Exit 44 to Required Checks Read From isRequired #2724: make scripts/pr_review.py wait take exit 44 (status=CHECKS_NOT_MERGEABLE) only where a stuck check is required, read from the isRequired field the full query already fetches on every rollup member, and the merge reads BLOCKED. Done looks like: a stuck optional check on a BLOCKED merge no longer exits 44, a stuck required one still does, the scripts/README.md paragraph and the code comment above the 44 arm state the isRequired reading instead of the call-cost rationale, and a test pins both cases. Drive the pull request to develop with Closes on promotion: #2724 in its body.

External blockers

None known at pick time.

Internal dependencies

None. The issue is self-contained in scripts/pr_review.py, its test module, and scripts/README.md.

State

The parked decision queue

Zero parked decisions on this lane.

What the last round did

Picked #2724 from the open backlog as the top-ranked auto-resolvable issue: a correctness defect in hub tooling that runs on every review wait, filed in review on #2722, with a determined outcome and no maintainer question open on it.

What not to repeat

Nothing yet.

New learnings

None yet.

Activity

  1. added
    handoffA link in the session handoff chain, one open issue per track
    on Oct 10, 2026
  2. ptr727 commented on Oct 10, 2026

    @ptr727
    OwnerAuthor

    Lane closed out, scope develop.

    • Merged Narrow pr_review.py wait's Exit 44 to Required Checks #2727 into develop as e62aea1, carrying Closes on promotion: #2724. Narrow pr_review.py wait's Exit 44 to Required Checks Read From isRequired #2724 stays open until a develop -> main promotion carries it.
    • wait now takes exit 44 only where a stuck check reads isRequired and the merge reads BLOCKED. The 44 line names the required stuck checks. The README paragraphs, the module docstring and the comment above the arm state the isRequired reading. Tests pin the optional and required cases and the naming.
    • Review: three local strict passes, the last with no findings. Copilot covered the head with 0 findings, all 13 checks green. CodeRabbit skipped automatic review, which is advisory.
    • Filed nothing along the way. Worktree, local branch and remote branch removed after the merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    handoffA link in the session handoff chain, one open issue per track

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions