Share One Bounded Backoff Loop Between pr_review.py wait's Two Polls

[ptr727]

Summary

• scripts/pr_review.py wait now runs both of its polls through one backoff helper on the POLL_DELAYS schedule, so a fix to the timeout check or the delay schedule lands once. The Copilot poll passes in its initial (done, answer, drift) tuple, so the --ignore-quota-signal path that forces done false still holds for the first evaluation, and re-reads through live_state, now extended to return those three readings rather than left as an unused sibling.
• The held-head check poll re-reads a narrower Q_HELD document, the fields its readers use, sharing one HELD_FIELDS fragment with Q_FULL. A Q_HELD read that would end the poll is re-read as Q_FULL first, so the poll stops only on the full payload the verdict then grades, and a poll that never sleeps grades its first read with no extra call. On the timeout the verdict takes a fresh Q_FULL.
• Tests: two new backoff cases pin the delay schedule and the timeout bound, a case pins Q_HELD leaving out the threads and files, and two wait cases pin the query sequence and the full-read confirmation. The existing wait tests pass unchanged. Two other existing tests changed: the contract test that scraped a local delays list now reads POLL_DELAYS, and the two live_state tests take its new return shape.

Closes on promotion: #2723

Local review

Three local-strict-review passes ran, and the edit budget is spent. Disposed of so far:

• PEP 695 def backoff[Polled] needs Python 3.12. Declined: spec/host-tools.json sets the interpreter floor at 3.13, and ruff's default rules under target-version = "py313" (UP047) refuse the TypeVar form.
• Two duplications that predate this change, the liveness triple computed both inline and per iteration and a held wait's back-to-back Q_FULL reads, are filed as Deduplicate pr_review.py wait's Liveness Triple and Its Back-to-Back Held Q_FULL Reads #2731.

Still open, each introduced:

• Test gap. The answer fake ignores the query, so every Q_HELD read in the suite carries reviewThreads and files. Replacing final = polled if any(polled is f for f in fulls) else None with final = polled passes the suite, although on a held timeout ending on a Q_HELD read the digest would raise a KeyError on reviewThreads.
• Design. The fulls list and its identity scan do more than the job needs, since only the last full read can be the returned value.

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 2b382dad-a246-4b51-b9fa-8a90ceeff674

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@c286e95). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #2732   +/-   ##
==========================================
  Coverage           ?   59.83%           
==========================================
  Files              ?       16           
  Lines              ?     8367           
  Branches           ?        0           
==========================================
  Hits               ?     5006           
  Misses             ?     3361           
  Partials           ?        0           

Flag	Coverage Δ
python-3.13	59.83% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

🟡 Changes recommended

Unresolved moderate findings affect timeout handling coverage and polling efficiency.

2 open findings

• Track only the latest full payload during held waits · New
• Test narrow held polling with a fresh full-read fallback · New

What changed in this PR

This PR centralizes bounded polling in pr_review.py wait, narrows held-head queries, and expands regression coverage.

Changes:

• Adds shared backoff and held/full query handling.
• Updates live-state and polling tests.
• Adds coverage for timing and confirmation reads.

File	Summary	Findings
scripts/​pr_review.py	Adds shared polling and held/full query logic.	P1 narrow-payload timeout test gap; P2 full-read retention and snapshot reuse issues.
tests/​test_pr_review.py	Updates and expands polling coverage.	P2 test does not exercise the actual narrow payload.

🧠 Review effort: Lite

---

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[ptr727]

Local review dispositions since this pull request opened:

• Test gap (listed open in the body), fixed in d5d13cc. A case serves Q_HELD without reviewThreads or files and times out on a narrow read, so grading that read instead of a fresh Q_FULL raises and fails the case.
• Design, the list of full reads (listed open in the body), fixed in d5d13cc. One last_full reference replaces it, since only the last full read can be the returned value.
• Design, a fourth pass over d5d13cc: the narrower held-poll query is complexity Share One Bounded Backoff Loop Between pr_review.py wait's Two Polls #2723 does not ask for. Declined: the maintainer's comment on Share One Bounded Backoff Loop Between pr_review.py wait's Two Polls #2723 widens its scope to exactly that, "A narrower poll document with Q_FULL kept for the final read would cut each iteration's cost."

[ptr727]

A recorded local strict-review pass covers head d5d13ccc2ef9327f88d2ea5b89f3723677adf3f2, the content this pull request carries at that commit against develop, and it recorded 1 finding.