Skip to content

Clarify shorthand SPA - Solar Position Algorithm - #2885

Merged
cwhanse merged 4 commits into
pvlib:mainfrom
RDaxini:atm_machine
Oct 6, 2026
Merged

cwhanse merged 4 commits into
pvlib:mainfrom
RDaxini:atm_machine

Conversation

@RDaxini

@RDaxini RDaxini commented Oct 5, 2026 •

Copy link
Copy Markdown
Member
  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license no AI
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Minor. Has bugged me for a minute and then #2873 brought it to my attention again.

  1. Main point: SPA Algorithm (Solar Position Algorithm Algorithm...)
  2. Extra: Might as well write SPA out in full at least once somewhere that is not in a reference) to define the abbreviation

Don't think this warrants a whatsnew entry but I listed myself as a contributor at least. Will add a description the whatsnew if recommended.

@RDaxini RDaxini added this to the v0.16.2 milestone Oct 5, 2026
@RDaxini RDaxini changed the title SPA - Solar Position Algorithm Clarify shorthand SPA - Solar Position Algorithm Oct 5, 2026
@cwhanse
cwhanse merged commit e37bc1a into pvlib:main Oct 6, 2026
26 of 27 checks passed
@RDaxini
RDaxini deleted the atm_machine branch October 7, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants