Skip to content

docs: fix the new locale catalog path - #445

Open
xiehuanyi wants to merge 1 commit into
python-humanize:mainfrom
xiehuanyi:docs/current-locale-source-paths
Open

xiehuanyi wants to merge 1 commit into
python-humanize:mainfrom
xiehuanyi:docs/current-locale-source-paths

Conversation

@xiehuanyi

Copy link
Copy Markdown

The README new-locale command writes to humanize/locale, although the source checkout stores catalogs under src/humanize/locale. It also requires the destination directory to exist.

Changes proposed in this pull request:

  • Use the current source-catalog path in msginit.
  • Create the new locale’s LC_MESSAGES directory before generating the catalog.

Validation: in an isolated temporary checkout, reproduced msginit failing on the old output path. Executed the corrected README commands with cs_CZ and --no-translator for noninteractive validation; the catalog was created at the source path and passed msgfmt --check. Generated existing translation binaries and ran the full suite: 854 passed, 2 skipped. prek run --all-files passes.

AI assistance: prepared and verified with OpenAI Codex.

Copilot AI balanced review requested due to automatic review settings October 7, 2026 10:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants