Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go to definition on a
collections.namedtuplefield can returnfile:///None: Jedi supplies a generated definition with a line and column but no source path. Skip those definitions before building LSP locations. The existing position checks remain in place, and navigable source and builtin definitions retain their behavior.Fixes #696.
Validation on Python 3.13 / Jedi 0.20.0: the real Document/Jedi regression fails before the fix with
file:///None; three controls pass. After the fix, all 15 definition and type-definition tests pass, including bothfollow_builtin_definitionssettings and source-backed locations. Ruff 0.9.4 lint and formatting pass for all 70 files inpylspandtest. The full platform/plugin suite was not run locally.OpenAI Codex assisted with the code, regression tests, and this description. The final patch received an independent AI review.