Render tz-aware times as local times without an offset - #613
Merged
frostming merged 1 commit intoSep 30, 2026
Merged
Conversation
Contributor
|
Please resolve the conflict |
item() and Time._new built the raw literal with time.isoformat(), which includes the UTC offset for tz-aware values - e.g. 07:32:00+02:00. TOML local times have no offset or timezone (the spec's examples are plain 07:32:00), and this library's own parser rejects the offset, so the serialized document was invalid and could not be read back. Render from hour/minute/second/microsecond only; naive times are unaffected.
Master-Norna
force-pushed
the
fix/time-tzinfo-serialization
branch
from
September 30, 2026 01:24
9597354 to
dc2cc45
Compare
Contributor
Author
|
Rebased onto the latest master — the conflict was with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
item()andTime._newbuilt the raw literal withtime.isoformat(), which includes the UTC offset for tz-aware values - e.g.07:32:00+02:00. TOML local times have no offset or timezone (the spec's examples are plain07:32:00), and this library's own parser rejects the offset, so the serialized document was invalid and could not be read back:Render from hour/minute/second/microsecond only. Naive times are byte-for-byte unchanged.
Agent Drafting Metadata