Repository navigation
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep compiled extensions out of source distributions generated by the C++, C++/JS/WASM, Rust, and Rust/JS/WASM templates. Native artifact patterns currently apply globally, so Hatch includes existing binaries even when sdist exclusions list them. Move those patterns to the wheel target and explicitly exclude
.so,.dll,.dylib, and.pydfrom sdists. Preserve existing JavaScript asset selection in both hybrid templates.Add a CI archive check that seeds compiled files into generated projects and verifies sdists exclude them while retaining C++/Rust sources. The check fails on all four original templates and passes after the fix.
Regenerated all four variants and passed development setup, lint, distribution checks, and tests locally. Also verified a generated C++ project with a real compiled extension: its sdist excludes the binary and its wheel includes it. Script Ruff checks and
git diff --checkpass.