Repository navigation
Typing cleanups 2 - Make all the handlers inherit from IHandler protocol to remove casts, consolidate tests. - #829
Draft
ThosRTanner wants to merge 2 commits into
Draft
ThosRTanner wants to merge 2 commits into
ThosRTanner wants to merge 2 commits into
Conversation
ThosRTanner
force-pushed
the
typing_cleanups_2
branch
from
October 17, 2026 06:35
a5276bb to
d719a7a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #829 +/- ##
==========================================
- Coverage 94.90% 90.44% -4.47%
==========================================
Files 27 27
Lines 3811 3799 -12
==========================================
- Hits 3617 3436 -181
- Misses 194 363 +169 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #828 (oddly)
Depends on #801
Why is this needed?
This makes the type checking safer and allows us to remove a lot of casting.
Proposed Changes
Does this PR introduce any breaking change?
No.