Repository navigation
Conversation
Add Python 3.15 and pypy 3.12 to testing matrix
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #816 +/- ##
==========================================
- Coverage 97.26% 94.46% -2.80%
==========================================
Files 3 3
Lines 7859 7859
==========================================
- Hits 7644 7424 -220
- Misses 215 435 +220
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
3.10 only just went out of support, I think in previous years we waited a little longer? 3.9 can definitely go though. |
|
I'm not sure there's any necessary reason to keep 3.10 support around, it's just a (small) maintenance burden. There aren't any major features planned to be added soon, but also the previous versions of typing-extensions will be around for people who still want to support 3.10. |
|
I agree that there's not really any harm in dropping support for 3.10 at this point, but it seems like it's also very easy for us to just pin to an older version of Ubuntu rather than using |
Meh, that just postpones the problem, and we have a fix ready now. That means someone has to either remember this PR or write it again in a few months. Also, ubuntu-22.04 either is already or will become unmaintained by GitHub at some point, meaning we won't get any new Python versions for it, and I doubt we will notice that, which means that we will silently test only against outdated Python (patch) versions. |
|
@JelleZijlstra @AlexWaygood To unblock CI: I would prefer to drop 3.10 and keep "ubuntu-latest" for the reasons given. If you insist that we should keep 3.10, I will change the PR accordingly, but I'd like to get this in fairly soon. |
AlexWaygood
left a comment
There was a problem hiding this comment.
I'm definitely not insisting, I don't particularly feel strongly! Changing the ubuntu pin feels like the easier/safer option to me, but I do agree that continuing to support 3.10 doesn't really buy us much at this point.
This comment was marked as off-topic.
This comment was marked as off-topic.
| - "3.10.20" | ||
| - "3.11" | ||
| - "3.11.0" | ||
| - "3.11.15" | ||
| - "3.12" | ||
| - "3.12.0" | ||
| - "3.12.13" | ||
| - "3.13" | ||
| - "3.13.0" | ||
| - "3.13.13" | ||
| - "3.14" | ||
| - "pypy3.9" | ||
| - "pypy3.10" | ||
| - "3.14.6" | ||
| - "3.15" | ||
| - "3.15.0" | ||
| - "pypy3.11" | ||
| - "pypy3.12" |
There was a problem hiding this comment.
I thought the idea with these was that we were deliberately testing the earliest patch version of each minor version, because we ran into issues in the past where 3.13.0 had a bug where 3.13.1 did not, so we had to make sure that our backports worked with both versions
There was a problem hiding this comment.
Yes. The .0 versions are unfortunately not available on Ubuntu 26.04, these are the earliest version. On the other hand, the latest versions will not be available on Ubuntu 24.04 going forward, since that won't be updated.
Add Python 3.15 and pypy 3.12 to testing matrix
This PR doesn't yet remove 3.9/3.10-specific code branches.