Repository navigation
Parse TMX object-reference properties as integer IDs - #84
Open
civilwarinfrance wants to merge 2 commits into
Open
civilwarinfrance wants to merge 2 commits into
civilwarinfrance wants to merge 2 commits into
Conversation
Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TMX properties with
type="object"currently fall through to string handling, while JSON properties preserve numeric IDs. A reference to object 2 therefore becomes"2", causing lookup in an integer-keyed object table to fail. Convert these values to integer IDs, including zero for an unset reference and references nested in class properties.This follows the Tiled specification: https://doc.mapeditor.org/en/stable/reference/tmx-map-format/#property
All six regression cases fail upstream and pass with the fix. They cover zero, normal and large IDs, nested class properties, and loading a real temporary TMX map through
parse_mapand resolving the target object by ID. The full suite passes all 132 tests. Mypy, Ruff, flake8, Black, and isort checks pass.AI-assisted by Codex (GPT-6); prepared and tested by the assistant.