Skip to content

Build the docker image from a ciflow/docker label - #3977

Merged
huydhn merged 1 commit into
mainfrom
osdc/ciflow-docker
Oct 9, 2026
Merged

huydhn merged 1 commit into
mainfrom
osdc/ciflow-docker

Conversation

@huydhn

@huydhn huydhn commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor
  • Build the tutorials image from a ciflow/docker label instead of on every PR, because fork PRs can't get the AWS token needed to push to ECR.
  • The labeler adds the label when .ci/docker changes.

@meta-cla meta-cla Bot added the cla signed label Oct 8, 2026
@pytorch-bot

pytorch-bot Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3977

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ff5d4c0 with merge base c80a434 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn

huydhn commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor Author

Not needed for now: #3976 builds the image on its ciflow/docs run when it is missing, and carries the docker-build.yml trigger fixes. Keeping the branch in case we want a separate ciflow/docker label later.

@huydhn huydhn closed this Oct 8, 2026
@huydhn huydhn reopened this Oct 8, 2026
@huydhn

huydhn commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Reopened: #3976 is stacked on this again, and relies on it to build the image for PRs that change .ci/docker.

@huydhn
huydhn marked this pull request as ready for review October 8, 2026 23:30
@huydhn
huydhn requested a review from atalman October 8, 2026 23:30
@huydhn
huydhn merged commit ca960b6 into main Oct 9, 2026
27 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants