Repository navigation
feat(assistant): improve conversation continuity and responsiveness - #271
Merged
Merged
Conversation
Deploying document with
|
| Latest commit: |
bdda0d0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7d20fb57.document-7hm.pages.dev |
| Branch Preview URL: | https://fix-speech-first-permission.document-7hm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Verdict
[APPROVE]
Final source review, local regression, deployed assistant acceptance and all reported CI checks passed at exact head
bdda0d0a274f7c5dae50d8547874bd7a612c4595. Functional commits remain separate; this PR is not merged.Summary
Risk Analysis
Cross-cutting lifecycle changes retain per-request identity, verified document outcomes, original-document scope checks and physical inference/Apply settlement. Drafts and pending questions remain volatile, and disk history stays opt-in. Model defaults, dependencies, persistence contracts and document review permissions are unchanged.
Design Decisions
The implementation borrows stable incremental presentation and explicit scroll ownership from Streamdown and DeepSeek Harness while retaining the existing TypeScript, safe Markdown renderer and Worker architecture. Oversized automatically formatted content uses exact raw text, with explicit expansion for large restored messages. Long model context trims older complete turns using an exactly verified budget; semantic summarization is not added.
Code Concerns
The integration review and independent focused dictation-repair review found no blocking issues within this PR. Three recognition phases and all four editors cover the title-navigation draft ownership regression. The focused repair, tests and acceptance record are one separate commit,
bdda0d0.Verification
Conclusion basis: Verified
bdda0d0: all 5,858 unit tests in 200 files passed with the existing coverage thresholds; lint, workspace/application types, formatting and production build passed. Both archive-aware checks verified all 1,511 immutable evaluation artifacts.bdda0d0, including each editor's original and destination draft isolation.bdda0d0: regular E2E, Docker-image E2E, Cloudflare-semantics E2E, timing budgets, lint/validation, Cloudflare deployment, real-preview smoke and PR title validation. No merge has been performed.Chromium probes covered delayed history hydration, request preparation, conversation-only replies during editor changes, dictating a queued next draft, stable streaming nodes, Stop with a 108KB partial answer, native scroll interruption and bounded history restoration. English/Chinese layouts were inspected at three widths in light/dark themes, including keyboard and reduced motion. Actual presentation observers were verified against visibility, Stop and replacement ownership; timing records contain numeric fields and status only.
Limits: Controlled speech and transport fixtures do not certify the user's microphone or physical local-GPU first-token/drain time. DOM presentation timing is not compositor paint timing.
Acceptance record · Reference review
Exact-head CI · Immutable preview