fix: compile Node 24+ prebuilds as C++20

[erunion]

Problem

The 3.3.0 publish run failed while building the macOS Node 24 prebuild (job). Fail-fast cancelled the rest of the build matrix, so the package was never published.

prebuildify compiles each release binary with node-gyp --target=<that Node version>. For this run the Node 24 target was 24.18.0. utils/defaultCxxStandard.js treated every --target as an Electron version, and Electron versions below 32 are compiled as C++17. The Node 24 build was therefore forced onto -std=c++17.

That flag replaces the gnu++20 default that ships in Node's headers (common.gypi). Node 24.18's V8 headers require C++20, so compilation stopped in src/async_worker.cc:

v8config.h:13:2: error: "C++20 or later required."

The same override is in the Linux cflags_cc path. Those jobs were cancelled when the macOS build failed, before they reached the C++ sources. The musl jobs are a separate matrix and succeeded: their Docker build sets CXXFLAGS, which makes binding.gyp skip its own -std flag and leave Node's gnu++20 in place.

The test workflow on the same commit passed. npm install there does not pass --target, so the standard comes from the running process's Node ABI. Node 24 is ABI 137, which already selects C++20.

Fix

--target is now read as a Node version. Electron and NW.js are detected on their own, from npm_config_runtime (electron or node-webkit) or from built_with_electron in the downloaded headers.

• Node 23 and newer, including the Node 24 and 26 prebuilds, compile as C++20.
• Node 18 through 22 stay on C++17.
• Electron 21 through 31 stays on C++17. Electron 32 and newer stays on C++20.

Tests

utils/defaultCxxStandard.test.js runs at the start of npm test (from test/index.js, before Mocha) and at the start of npm run mocha. CI uses npm test, so these checks run on every test job. They do not load the native addon.

Node fixtures drop an inherited npm_config_runtime. An Electron or NW.js install environment no longer makes the Node 23 and 24 checks select C++17 and stop the suite. Tests that pass npm_config_runtime explicitly still cover the Electron mapping.

Workflow names

.github/workflows/publish.yml is named Publish and .github/workflows/tests.yml is named Tests, so the Actions list no longer shows those workflows by filename. Prebuilds stay inside Publish; they are not a separate workflow that runs on every pull request.

  

[erunion]

@greptileai

[greptile-apps]

Confidence Score: 5/5

[High impact] This PR appears safe to merge; the workflow name additions introduce no identified failures.

_{Reviews (4) · Last reviewed commit: "ci: name the Publish and Tests workflows" · Reviewed by Greptile}