Repository navigation
Conversation
Move the native prebuild jobs into a Build workflow that runs on every pull request and on master and backport pushes. Publish calls that workflow for release tags, then publishes the artifacts. Name the Build, Publish, and Tests workflows so they show up in the Actions list. Co-authored-by: Jon Ursenbach <erunion@users.noreply.github.com>
 |
Pull request and branch builds compile the native binaries and discard them. Publish opts in to artifact upload, so a release cannot pick up a prebuild produced by another run. Co-authored-by: Jon Ursenbach <erunion@users.noreply.github.com>
erunion
added this pull request to stack #30
October 8, 2026 22:43
An error occurred while trying to automatically change base from
erunion/fix-node24-prebuild-cxx20-a34f
to
master
October 9, 2026 01:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Native prebuilds only ran inside the publish workflow, on
v*tags and manual dispatch. A pull request could merge without ever compiling the release binaries, which is how the Node 24 macOS prebuild failure showed up only at release time.The Actions tab also listed the workflows by filename (
.github/workflows/publish.yml,.github/workflows/tests.yml) because they had noname.Change
Prebuild jobs now live in
.github/workflows/build.yml(name: Build). That workflow runs on every pull request and on pushes tomasterandbackport/*. It still builds the same matrix: glibc and macOS prebuilds for Node 22, 24, and 26, plus the musl images.Those CI runs compile and then discard the binaries. They do not upload artifacts. Pull request prebuilds use the same artifact names as a release (
prebuild-macOS-ARM64-node24and so on). Keeping them in artifact storage would let a later download-by-name, including a fork pull request, be picked up as the release binaries..github/workflows/publish.yml(name: Publish) calls Build withupload-artifacts: trueonv*tags andworkflow_dispatch, then downloads the artifacts from that run and publishes. The publish steps are otherwise unchanged..github/workflows/tests.ymlis namedTests. Its jobs and triggers are unchanged.