Repository navigation
tdd-ai-agents: Treat missing release segments as zero - #877
Merged
Merged
Conversation
Version("1.2") compared unequal to Version("1.2.0") because ._key()
compared raw release tuples. Trim trailing zeros in ._key() and add
test_missing_segments_count_as_zero() to match the updated tutorial.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #807, matching an update to the TDD With AI Agents tutorial.
The
._key()method compared raw release tuples, soVersion("1.2") == Version("1.2.0")wasFalse. That goes against Python's version rules and the tutorial's text. It also meant that1.2.0.dev1sorted after1.2.version_check/core.py:._key()now trims trailing zeros from the releasetests/test_core.py: Addstest_missing_segments_count_as_zero()with three casesThe suite passes: 22 tests, up from 19. ruff and black report no issues.
🤖 Generated with Claude Code