Repository navigation
Conversation
Collaborator
|
The code is not up to standard, and way too bloated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit multi-source and All compatible source selection while preserving the original single-source picker. Preserve source identities and row ownership for pagination. Show partial results, bound catalogue concurrency to three and serialize calls to the same provider, retaining successful rows when another provider fails or times out. Publish rows before waiting for featured metadata; bound featured and recommendation work separately.
Offer six or twelve recommendations with All/per-source filtering. Start with native related titles; consult matching titles in selected direct providers and then fill from same-type catalogue suggestions if necessary. Catalogue suggestions are not claimed to be semantically related recommendations. Exclude the current title and presentation duplicates without merging histories. Do not fabricate twelve results when the sources do not supply enough.
Related to #300. Regression tests cover partial results, ordering, cancellation, concurrency and recommendation selection. Physical pagination, D-pad focus, source behavior and latency measurement remain pending. Card scaling and featured-count presentation are submitted separately.
Validation:
:library:checkKotlinAbi,:app:testPrereleaseDebugUnitTest, and:app:assemblePrereleaseDebugpassed locally. 15 JVM tests passed without failures or errors. Lint is left to this PR's GitHub workflow; the complete integration branch previously passed Lint. These results are not physical-device validation.AI disclosure: implementation, code review and automated test execution used OpenAI Codex assistance, as required by AI-POLICY.md. This draft submits the implemented work for human review; pending physical checks and limitations above are not claimed complete. No changes to provider source code or the projector launcher are included.