Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds higher playback speeds and configurable long-press speed.
Long-press was fixed at 2x, so it did nothing for anyone already watching at 2x.
Changes
PlaybackSpeeds.kt: New, Limits and escalation logic shared by the dialog and gesture helper.PlayerGestureHelper.kt,FullScreenPlayer.kt: for the hold gesture and dialog bounds.SettingsPlayerScreen.kt,DevicePreferenceStore.kt,settings_player.xml,array.xml, strings: newspeedup_speed_keypref (percent, 200 = 2x).speed_dialog.xml: two rows of presets, D-pad focus chain updated. The speed-up indicator in the phone, TV and trailer layouts is nowwrap_contentso the text fits.The speed button and long-press speed-up now default to on (previously off). Explicit user choices are unaffected. Happy to revert this if you'd rather keep the old defaults.
Testing
assemblePrereleaseDebugand tested on multiple Android phones../gradlew lint checkpasses.Note: This implementation was written with AI assistance (Claude). I tested the change on a device and can explain and fix all of it if needed.