Repository navigation
[CodingStyle] Fix NewlineBeforeNewAssignSetRector false positive on local var and $this property name collision - #8535
Merged
TomasVotruba merged 1 commit intoOct 7, 2026
Conversation
…ocal var and $this property name collision
TomasVotruba
deleted the
fix-8534-newline-assign-this-property-collision
branch
October 7, 2026 12:12
Member
Author
|
This should be fixed as variable and property name are not the same logical concept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8534
When a local variable and a class property share the same name,
resolveCurrentStmtVariableName()resolved both to the same bare string. A$this->queryassign returned the property namequery, colliding with a local$queryvariable.Two consecutive same-name entries then tricked the grouping into inserting a blank line before the next statement.
Fix: namespace the $this property result as
this->property, so it can no longer match a local variable of the same name. Real runs of the same property still group correctly.