Repository navigation
Add A/B perf benchmark script - #8536
Open
TomasVotruba wants to merge 3 commits into
Open
TomasVotruba wants to merge 3 commits into
TomasVotruba wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A/B perf benchmark script
scripts/rector-ab-benchmark.phpmeasures the current checkout against a project (defaults to a shallow clone oflaravel/laravel), reporting median cold and warm wall time, peak RSS, and a fingerprint of the changed-file set so a speed change that alters behavior is caught. Run it once per ref with--save/--baselineto compare two refs. It never switches git refs itself, so it is safe to run while other work happens in the repo.Excluded from PHPStan like the sibling
rector-jobsize-benchmark.php(shells out, parses getopt by hand).I used it to check two ports of recent PHPStan speedups and both showed no measurable gain in Rector, so neither is included here:
xxh128, so the file read it would skip is not a real cost (PHPStan's win was from sha256 over large files).