Skip to content

Fix windows CI error on ChangedFilesDetectorPortableCacheTest - #8537

Merged
samsonasik merged 1 commit into
mainfrom
fix-windows-cache
Oct 9, 2026
Merged

samsonasik merged 1 commit into
mainfrom
fix-windows-cache

Conversation

@samsonasik

Copy link
Copy Markdown
Member

Per #8522 (comment)

Error on windows CI scheduled https://github.com/rectorphp/rector-src/actions/runs/36757144121/job/110030152386#step:5:110 :

1) Rector\Tests\Caching\Detector\ChangedFilesDetectorPortableCacheTest::testConfiguredPathsDoNotTieTheCacheToOneDirectory
the configured paths made the same configuration hash differently in another checkout
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'bd2eac7cb73a3121491dc50cce345f419bce8b77'
+'92be4777ae036a66439d83436dca20ea5d3f63f5'

D:\a\rector-src\rector-src\tests\Caching\Detector\ChangedFilesDetectorPortableCacheTest.php:225

@samsonasik

Copy link
Copy Markdown
Member Author

@TomasVotruba ready 👍

@samsonasik

Copy link
Copy Markdown
Member Author

@TomasVotruba let's test this and check if this will work on next scheduled Windows CI 👍

@samsonasik
samsonasik merged commit 9fa959b into main Oct 9, 2026
50 checks passed
@samsonasik
samsonasik deleted the fix-windows-cache branch October 9, 2026 08:11
@samsonasik

samsonasik commented Oct 9, 2026 •

Copy link
Copy Markdown
Member Author

@TomasVotruba Windows CI is works now 🎉 🎉 🎉

Screenshot_20261009_151735_Firefox

See https://github.com/rectorphp/rector-src/actions/runs/37903807943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant