Repository navigation
[perf] Skip use-imports resolve on preslash narrow path - #8538
Merged
Merged
Conversation
TomasVotruba
changed the title
TomasVotruba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ObjectTypeSpecifier::narrowToFullyQualifiedOrAliasedObjectType(),$uses = $this->useImportsResolver->resolve()ran on every call, but the result is only read inside the! $withPreslashbranch.The hot path is
NodeTypeResolver::getType(), which calls this method withwithPreslash: truefor everyObjectTyperesult - soresolve()ran and its result was discarded.resolve()walks the namespace and filters all file statements (FileNode::getUsesAndGroupUses()), uncached.Moving the call inside the branch where it is used removes that work from the preslash path. Behavior is identical.
Measured on a serial run over
rules/: this path fires ~27k times.