Repository navigation
[traversing] Decouple Rector rules from PhpParser NodeVisitor - #8541
Merged
Merged
Conversation
RectorInterface no longer extends NodeVisitor and AbstractRector no longer extends NodeVisitorAbstract. Rules are run only through the custom RectorNodeTraverser, which uses enterNode() and getNodeTypes(), so the beforeTraverse()/afterTraverse()/leaveNode() hooks were dead.
TomasVotruba
force-pushed
the
remove-nodevisitor-from-rector-interface
branch
from
October 8, 2026 17:00
7937fc1 to
68891fe
Compare
TomasVotruba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
RectorInterfaceno longer extendsPhpParser\NodeVisitor, andAbstractRectorno longer extendsNodeVisitorAbstract.Why
Rules are run only through the custom
RectorNodeTraverser, which callsenterNode()andgetNodeTypes(). ThebeforeTraverse(),afterTraverse()andleaveNode()hooks from theNodeVisitorcontract were never invoked on rules - dead surface kept alive only by the inheritance.Changes
RectorInterfaceextends onlyDocumentedRuleInterface;enterNode()is now declared explicitly on the contract (the engine calls it).AbstractRectordropsextends NodeVisitorAbstractand the dead, already-deprecatedleaveNode().DeprecatedRulesReporterguards itsbeforeTraversereflection withhasMethod(), since rules no longer carry that method by default.Follows up #8540, which removed the matching no-op
beforeTraverse()/afterTraverse()loops inRectorNodeTraverser.Local
composer complete-checkpasses.