Repository navigation
amiga: activate the packaged DOSDriver at mount - #26
Merged
Merged
Conversation
The sample CD0 entry left the handler unstarted until the first access, so a disc already in the drive had no Workbench icon until then. The Workbench work triggered by that late mount also halved CDBench's Discovery result, from about 7 500 to 3 900 entries/s. Set Activate = 1, as the README mountlist already does, and note how to save the memory by removing it. A drive that is empty at mount needs a device that reports TDERR_DiskChanged for TD_GETGEOMETRY: a4091.device 42.39 does not, so the handler declines and a disc there still waits for first access, as it did before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Activate = 1to the sampleCD0DOSDriver, so the handler starts at mount and a disc in the drive gets its Workbench icon without waiting for first access. The README mountlist already sets it.Tested in WinUAE with a4091.device, not on real hardware:
CD0is listed.Known limitation: a4091.device 42.39 returns error 52 rather than
TDERR_DiskChangedforTD_GETGEOMETRYon an empty drive, so the handler declines the mount. A disc inserted later then needs an access toCD0:to mount, which matches the behaviour withoutActivate. a4091-software commit5a151a1fixes the driver, but it isn't in a tagged release and this hasn't been tested with a build that contains it.